Repository navigation
Put the Wave 3 into standby from the climate entity and report its temperatures in Celsius - #508
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the Wave 3's climate entity turn the unit off into standby instead of powering it down, wakes it again from the same entity, and reports its temperature sensors in the unit the device actually sends.
cfg_power_offcuts the Bluetooth radio along with the unit, so a Wave 3 switched off from Home Assistant could only be switched back on at the unit itself; the app's own home-screen toggle usescfg_sys_pausefor off andcfg_power_onfor on, which keeps the link up. Powering down is still available, as a separate button that is disabled by default.Full list of changes:
cfg_power_on. An earlier attempt used acfg_sys_resumefield that looked like the obvious counterpart tocfg_sys_pause; regenerating the schema from the current EcoFlow app showed the device has no such field, which is why waking that way did nothing.Resolves #470