feat: add EvictSlowClients option to prevent slow subscribers blockin… - #192
Open
jeetvdevvee wants to merge 2 commits into
Open
feat: add EvictSlowClients option to prevent slow subscribers blockin…#192jeetvdevvee wants to merge 2 commits into
jeetvdevvee wants to merge 2 commits into
Conversation
…g stream.run() When a subscriber's 64-slot connection buffer is full, the original fan-out loop blocks the entire stream.run() goroutine, freezing all other connected clients until the slow client catches up or disconnects. Add EvictSlowClients bool field to Stream. When true, a non-blocking select/default evicts the stalled subscriber via removeSubscriber() instead of blocking. When false (default), the event is dropped for that subscriber but the goroutine continues — still an improvement over the original blocking behavior. removeSubscriber() is used instead of close() to avoid deadlocking the run goroutine on its own deregister channel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add EvictSlowClients option to prevent slow subscribers blocking stream.run()
When a subscriber's 64-slot connection buffer is full, the original
fan-out loop blocks the entire stream.run() goroutine, freezing all
other connected clients until the slow client catches up or disconnects.
Add EvictSlowClients bool field to Stream. When true, a non-blocking
select/default evicts the stalled subscriber via removeSubscriber()
instead of blocking. When false (default), the event is dropped for
that subscriber but the goroutine continues — still an improvement
over the original blocking behavior.