test: poll goroutine count to deflake TestSubscribeWithContextDone - #191
Open
c-tonneslan wants to merge 1 commit into
Open
test: poll goroutine count to deflake TestSubscribeWithContextDone#191c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
The fixed 1 second sleep after cancel() was racing the subscriber goroutines on busy CPUs. The Debian packagers can reproduce it with 'taskset -c 0,1 go test' (r3labs#186). Replace the sleep with a 10s polling loop. The test still fails in a reasonable time if the goroutines genuinely leak, and it doesn't fail on a slow scheduler. Closes r3labs#186 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #186.
The fixed 1-second sleep after `cancel()` was racing the subscriber goroutines on busy CPUs. The Debian packagers can repro reliably with `taskset -c 0,1 go test`.
Swap the sleep for a 10-second polling loop. The test still fails in a reasonable time if the goroutines genuinely leak, but it doesn't blow up just because the scheduler got slow.