Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟡 Changes recommended
The availability-zone value will not be populated from the node label as implemented.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the Quickwit Helm chart to set QW_AVAILABILITY_ZONE on Kubernetes 1.33+ and bumps the chart version.
Changes:
- Adds version-gated availability-zone environment configuration.
- Uses a prerelease-inclusive Kubernetes version constraint.
- Bumps the chart version to
0.8.18.
File summaries
| File | Summary | Review |
|---|---|---|
charts/quickwit/templates/_helpers.tpl |
Adds conditional QW_AVAILABILITY_ZONE configuration. |
Moderate issue: the node topology label is not normally present on Pod metadata, so the value will be empty without explicit propagation or configuration. |
charts/quickwit/Chart.yaml |
Bumps the chart version to 0.8.18. |
No issues noted. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - name: QW_AVAILABILITY_ZONE | ||
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: metadata.labels['topology.kubernetes.io/zone'] |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set
QW_AVAILABILITY_ZONEfrom the pod'stopology.kubernetes.io/zonelabel on Kubernetes 1.33 and newer.The constraint intentionally uses
>=1.33.0-0rather than>=1.33.0. Helm treats provider suffixes such as GKE'sv1.35.3-gke.1389002as prereleases, so>=1.33.0would exclude them and omit the environment variable from live manifests.Also bumps the chart patch version to
0.8.18.Validation
Tested with Helm 4.2.2:
v1.32.9:QW_AVAILABILITY_ZONEomittedv1.33.0:QW_AVAILABILITY_ZONErenderedv1.35.3-gke.1389002:QW_AVAILABILITY_ZONErenderedv1.36.0:QW_AVAILABILITY_ZONErenderedhelm lint charts/quickwit: passes