Skip to content

FROMLIST: arm64: dts: qcom: sa8775p: Add qref and refgen supply for P… - #1733

Open
qianyu-qcom wants to merge 1 commit into
qualcomm-linux:tech/all/dt/qcs9100from
qianyu-qcom:tech/all/dt/qcs9100
Open

FROMLIST: arm64: dts: qcom: sa8775p: Add qref and refgen supply for P…#1733
qianyu-qcom wants to merge 1 commit into
qualcomm-linux:tech/all/dt/qcs9100from
qianyu-qcom:tech/all/dt/qcs9100

Conversation

@qianyu-qcom

Copy link
Copy Markdown

…CIe PHYs

The QMP PCIe PHYs on SA8775p require dedicated qref and refgen voltage supplies for stable operation. Without these supplies, the system may occasionally crash.

Add vdda-qref-supply and vdda-refgen-supply in the board files (Lemans-EVK, Lemans-RIDE, QCS9100-RIDE and QCS9100-RIDE-R3).

Link: https://lore.kernel.org/all/20260810112735.1326807-5-ziyue.zhang@oss.qualcomm.com/
Fixes: 94d7d37 ("arm64: dts: qcom: lemans-evk: Enable PCIe support")
Fixes: 76326da ("arm64: dts: qcom: lemans: Refactor ride/ride-r3 boards based on daughter cards")

…CIe PHYs

The QMP PCIe PHYs on SA8775p require dedicated qref and refgen voltage
supplies for stable operation. Without these supplies, the system may
occasionally crash.

Add vdda-qref-supply and vdda-refgen-supply in the board files
(Lemans-EVK, Lemans-RIDE, QCS9100-RIDE and QCS9100-RIDE-R3).

Link: https://lore.kernel.org/all/20260810112735.1326807-5-ziyue.zhang@oss.qualcomm.com/
Fixes: 94d7d37 ("arm64: dts: qcom: lemans-evk: Enable PCIe support")
Fixes: 76326da ("arm64: dts: qcom: lemans: Refactor ride/ride-r3 boards based on daughter cards")
Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com>
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qcomlnxci
qcomlnxci requested review from a team, knaveen-qc, Nicolas Dechesne (ndechesne) and Trilok Soni (trsoni) and removed request for a team August 24, 2026 02:58
@qlijarvis

Copy link
Copy Markdown

PR #1733 — validate-patch

PR: #1733

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/all/20260810112735.1326807-5-ziyue.zhang@oss.qualcomm.com/
  2. Lore link matches PR commits: Yes — diff content faithful to lore; context line numbers differ due to different baseline (expected for FROMLIST:)
  3. Upstream patch status: ⏳ In review — Reviewed-by from Krzysztof Kozlowski (2026-08-14); Manivannan Sadhasivam requested commit message clarification (2026-08-20); no merge or NAK decision yet
  4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1733 — FROMLIST: arm64: dts: qcom: sa8775p: Add qref and refgen supply for PCIe PHYs
Upstream commit: https://lore.kernel.org/all/20260810112735.1326807-5-ziyue.zhang@oss.qualcomm.com/
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream Identical except for FROMLIST: prefix (expected)
Body preserves rationale Key rationale preserved: "require dedicated qref and refgen voltage supplies for stable operation. Without these supplies, the system may occasionally crash."
Fixes tag present/correct Both Fixes tags present and match lore exactly
Authorship preserved From: matches lore author (Ziyue Zhang); both Signed-off-by: lines present
Backport note (if applicable) N/A Not a backport — FROMLIST: prefix indicates patch posted to mailing list but not yet merged

Diff

File Status Notes
arch/arm64/boot/dts/qcom/lemans-evk.dts:897 Identical code change; context line numbers differ (lore: 851, PR: 897) — expected for different baseline
arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi:981 Identical code change; context line numbers differ (lore: 983, PR: 981) — expected for different baseline
arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts:14 Identical — adds vdda-refgen-supply for both PHYs
arch/arm64/boot/dts/qcom/qcs9100-ride.dts:14 Identical — adds vdda-refgen-supply for both PHYs

Upstream Patch Status

Commit Community Verdict
arm64: dts: qcom: sa8775p: Add qref and refgen supply for PCIe PHYs Decision Pending — Reviewed-by: Krzysztof Kozlowski (dt-bindings maintainer) on 2026-08-14; Manivannan Sadhasivam (PHY maintainer) requested additional commit message context on 2026-08-20; no merge/NAK decision yet

qcom-next/topics Presence

Commit Status
FROMLIST: arm64: dts: qcom: sa8775p: Add qref and refgen supply for PCIe PHYs ⚠️ Partial — integration_presence_report.md shows "partial - subject or partial tree evidence found, but full change was not verified"

Verdict

Merge as-is. The PR faithfully represents the lore patch (patch 4/4 of series v1). Diff content is identical; context line number differences are expected and acceptable for a FROMLIST: patch applied to a different baseline. Commit message preserves all key information including rationale, Fixes tags, and authorship. The patch has received Reviewed-by: from the dt-bindings maintainer and is under active review by the PHY maintainer.

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/all/20260810112735.1326807-5-ziyue.zhang@oss.qualcomm.com/
  2. Lore link matches PR commits: Yes — diff content faithful to lore; context line numbers differ due to different baseline (expected for FROMLIST:)
  3. Upstream patch status: ⏳ In review — Reviewed-by from Krzysztof Kozlowski (2026-08-14); Manivannan Sadhasivam requested commit message clarification (2026-08-20); no merge or NAK decision yet
  4. PR present in qcom-next/topics: Partial — per integration_presence_report.md: "partial - subject or partial tree evidence found, but full change was not verified"

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 3c1e80ceb9fb6978aa94bc0624e7c0003f3b4f6e
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: arm64: dts: qcom: sa8775p: Add qref and refgen missing - no subject, patch-id, or full tree-content match found partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

@qlijarvis

Copy link
Copy Markdown

PR #1733 — checker-log-analyzer

PR: #1733
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32684833900

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ CI merge failure - no checker execution
dt-binding-check ⚠️ CI merge failure - no checker execution
dtb-check ⚠️ CI merge failure - no checker execution
sparse-check ⚠️ CI merge failure - no checker execution
check-uapi-headers ⚠️ CI merge failure - no checker execution
check-patch-compliance ⚠️ CI merge failure - no checker execution
tag-check PASS - commit has valid FROMLIST: prefix
qcom-next-check N/A Not applicable (target: tech/all/dt/qcs9100)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1733 - FROMLIST: arm64: dts: qcom: sa8775p: Add qref and refgen supply for PCIe PHYs
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32684833900
Target branch: tech/all/dt/qcs9100

Checker Result Summary
checkpatch ⚠️ CI merge failure - no checker execution
dt-binding-check ⚠️ CI merge failure - no checker execution
dtb-check ⚠️ CI merge failure - no checker execution
sparse-check ⚠️ CI merge failure - no checker execution
check-uapi-headers ⚠️ CI merge failure - no checker execution
check-patch-compliance ⚠️ CI merge failure - no checker execution
tag-check PASS - commit has valid FROMLIST: prefix
qcom-next-check N/A Not applicable (target: tech/all/dt/qcs9100)

⚠️ CI Infrastructure Failure

Root cause: All checker jobs failed during the merge phase with "fatal: refusing to merge unrelated histories" before any actual checker validation could run.

Failure details:

2026-08-24T03:16:41.0522528Z fatal: refusing to merge unrelated histories
2026-08-24T03:17:03.1494578Z Merge failed or conflicts detected. Aborting merge.
2026-08-24T03:17:03.1513262Z fatal: There is no merge to abort (MERGE_HEAD missing).
2026-08-24T03:17:03.1533894Z ##[error]Process completed with exit code 3.

This error occurred identically across all six checker jobs (checkpatch, dt-binding-check, dtb-check, sparse-check, check-uapi-headers, check-patch-compliance) during the CI workflow's attempt to merge the PR branch with the integration baseline.

Analysis:

The "refusing to merge unrelated histories" error indicates that the CI infrastructure encountered a Git history incompatibility when attempting to merge:

  1. The baseline integration branch (based on tag 3c1e80ceb9fb6978aa94bc0624e7c0003f3b4f6e)
  2. The topic branch topic/tech/all/dt/qcs9100
  3. The PR branch pr-1733

This is a CI infrastructure/configuration issue, not a patch quality defect. The patch itself could not be validated because the checkers never executed.

Fix: Re-trigger the CI workflow. If the issue persists, the repository maintainers may need to:

  • Verify the base branch tech/all/dt/qcs9100 has a common ancestor with the integration baseline
  • Check if the topic branch configuration in the CI workflow is correct
  • Consider using git merge --allow-unrelated-histories in the CI merge script (if appropriate for this workflow)

Reproduce locally:

# This is a CI infrastructure issue and cannot be reproduced locally
# The patch itself can be validated with:
git fetch https://github.com/qualcomm-linux/kernel-topics.git pull/1733/head:pr-1733
git checkout pr-1733
./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES -g HEAD

✅ tag-check (Manual Verification)

Status: PASS

Analysis:

  • Target branch: tech/all/dt/qcs9100 (NOT qcom-next or qcom-next-staging)
  • Subject-prefix check: MANDATORY for this branch
  • Commit subject: FROMLIST: arm64: dts: qcom: sa8775p: Add qref and refgen supply for PCIe PHYs
  • Prefix: FROMLIST: ✅ (valid - indicates patch posted to mailing list)

The commit correctly uses the FROMLIST: prefix and includes a valid Link: tag pointing to the lore.kernel.org posting:

Link: https://lore.kernel.org/all/20260810112735.1326807-5-ziyue.zhang@oss.qualcomm.com/

📋 Patch Quality Assessment (from pr.patch)

Since the checkers did not execute, I performed a manual review of the patch:

Commit message quality: ✅ PASS

  • Has FROMLIST: prefix
  • Has Link: tag with valid lore URL
  • Has Fixes: tags (2) referencing the commits that introduced the boards
  • Has proper Signed-off-by: tags (2)
  • Commit body is clear and explains the change

Code changes: ✅ PASS

  • DTS-only changes (4 files modified)
  • Adds vdda-qref-supply and vdda-refgen-supply properties to PCIe PHY nodes
  • Changes are consistent across all affected board files
  • No code style issues visible

Expected checker results (prediction):

  • checkpatch: Likely PASS (DTS changes, proper commit format)
  • dt-binding-check: SKIP (no binding changes)
  • dtb-check: Likely PASS (adding supply properties to existing nodes)
  • sparse-check: SKIP (no C/H files changed)
  • check-uapi-headers: SKIP (no UAPI changes)
  • check-patch-compliance: Likely PASS (has FROMLIST prefix and Link tag)

Verdict

CI infrastructure failure prevented checker execution. The patch itself appears well-formed and ready for merge once CI is fixed.

Action required:

  1. Re-trigger the CI workflow to get actual checker results
  2. If the merge failure persists, escalate to repository maintainers to fix the CI configuration for the tech/all/dt/qcs9100 branch

Patch quality: Based on manual review, the patch follows all kernel coding standards and commit message requirements. No patch changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants