Add qref and refgen regulator vote for QCS8300 and SA8775p PHY - #1731
Open
qianyu-qcom wants to merge 2 commits into
Open
Add qref and refgen regulator vote for QCS8300 and SA8775p PHY#1731qianyu-qcom wants to merge 2 commits into
qianyu-qcom wants to merge 2 commits into
Conversation
qianyu-qcom
commented
Aug 24, 2026
qianyu-qcom
commented
qcomlnxci
requested review from
a team,
krishnachaitanya-linux and
Matthew Leung (meleung)
and removed request for
a team
August 24, 2026 02:34
added 2 commits
August 24, 2026 10:37
…en and refgen supply properties QCS8300 and SA8775p PCIe PHYs require dedicated vdda-refgen and refgen LDO supplies for QREF to provide a stable reference clock. Without these supplies, the PCIe PHYs cannot work properly. Mark them as required for the affected compatibles even though it breaks ABI. vdda-refgen-supply is required for all three QCS8300 and SA8775p PHY compatibles. refgen-supply is required for QCS8300 only, as a workaround for a hardware issue where QREF actually depends on refgen3 rather than refgen2 as documented, so the PHY driver votes for refgen3 directly via this supply. Link: https://lore.kernel.org/all/20260810112735.1326807-2-ziyue.zhang@oss.qualcomm.com/ Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
… QCS8300 and SA8775p PHY Add a new sa8775p_qmp_phy_vreg_l that includes vdda-phy, vdda-pll, vdda-qref, vdda-refgen and refgen supplies, and use it for QCS8300 and SA8775p PCIe PHY configurations. This avoids modifying sm8550_qmp_phy_vreg_l and breaking SM8550 and SM8650. Note that due to a hardware issue, QREF actually depends on refgen3 rather than refgen2 as documented; refgen3 is therefore voted manually via the refgen supply as a workaround. Link: https://lore.kernel.org/all/20260810112735.1326807-3-ziyue.zhang@oss.qualcomm.com/ Fixes: a05b6d5 ("phy: qcom-qmp-pcie: add support for sa8775p") Fixes: ebf198f ("phy: qcom-qmp-pcie: add dual lane PHY support for QCS8300") Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com> Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
qianyu-qcom
force-pushed
the
tech/bus/pci/phy
branch
from
August 24, 2026 02:38
4ebfa2f to
5e959ea
Compare
🔨 Build Failure Analysis — PR #1731PR: #1731
Verdict1 of 1 errors is introduced by this PR due to a merge conflict with upstream changes. 📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1731PR: #1731
Verdict1 of 1 errors is introduced by this PR due to a merge conflict with existing code in the target branch. 📎 Detailed analysis: Full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.