Skip to content

Drop redundant recompiles before ARM pass retracing - #22162

Open
apullin wants to merge 1 commit into
pytorch:mainfrom
apullin:export-D114790155
Open

Drop redundant recompiles before ARM pass retracing#22162
apullin wants to merge 1 commit into
pytorch:mainfrom
apullin:export-D114790155

Conversation

@apullin

@apullin apullin commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary:
Drop redundant recompile() before ARM pass retracing.

Remove redundant GraphModule.recompile() calls immediately before super().call(graph_module) in CanonicalizeViewCopyPermutePass and FuseDuplicateUsersPass. The following ExportPass retrace/interpreter does not consume compiled Python code object, so recompile adds wall time without changing graph.

Keep graph.lint() in modified paths for invariant checking. Behavior-preserving lowering speedup.

Differential Revision: D114790155

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Summary:
Drop redundant recompile() before ARM pass retracing.

Remove redundant GraphModule.recompile() calls immediately before super().call(graph_module) in CanonicalizeViewCopyPermutePass and FuseDuplicateUsersPass. The following ExportPass retrace/interpreter does not consume compiled Python code object, so recompile adds wall time without changing graph.

Keep graph.lint() in modified paths for invariant checking. Behavior-preserving lowering speedup.

Differential Revision: D114790155
@apullin
apullin requested a review from digantdesai as a code owner August 25, 2026 21:15
@pytorch-bot

pytorch-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22162

Note: Links to docs will display an error until the docs builds have been completed.

❌ 24 New Failures, 3 Unclassified Failures

As of commit 7b290a2 with merge base 469debd (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2026
@meta-codesync

meta-codesync Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@apullin has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114790155.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant