Drop redundant recompiles before ARM pass retracing - #22162
Conversation
Summary: Drop redundant recompile() before ARM pass retracing. Remove redundant GraphModule.recompile() calls immediately before super().call(graph_module) in CanonicalizeViewCopyPermutePass and FuseDuplicateUsersPass. The following ExportPass retrace/interpreter does not consume compiled Python code object, so recompile adds wall time without changing graph. Keep graph.lint() in modified paths for invariant checking. Behavior-preserving lowering speedup. Differential Revision: D114790155
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22162
Note: Links to docs will display an error until the docs builds have been completed. ❌ 24 New Failures, 3 Unclassified FailuresAs of commit 7b290a2 with merge base 469debd ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@apullin has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114790155. |
This PR needs a
|
Summary:
Drop redundant recompile() before ARM pass retracing.
Remove redundant GraphModule.recompile() calls immediately before super().call(graph_module) in CanonicalizeViewCopyPermutePass and FuseDuplicateUsersPass. The following ExportPass retrace/interpreter does not consume compiled Python code object, so recompile adds wall time without changing graph.
Keep graph.lint() in modified paths for invariant checking. Behavior-preserving lowering speedup.
Differential Revision: D114790155
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani