Skip to content

Speed up permute propagation cleanup - #22161

Open
apullin wants to merge 1 commit into
pytorch:mainfrom
apullin:export-D114224762
Open

Speed up permute propagation cleanup#22161
apullin wants to merge 1 commit into
pytorch:mainfrom
apullin:export-D114224762

Conversation

@apullin

@apullin apullin commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary:
Speed up permute propagation cleanup.

ARM lowering spends significant time in permute propagation. Reduce avoidable repeated work while keeping same optimizations:

  • Canonicalize view/permute chain collection now uses deque + membership set instead of list pop(0) and remove(), avoiding quadratic bookkeeping.
  • FuseDuplicateUsersPass deduplicates pending producer revisits while preserving same revisit behavior after fusions.
  • PropagateViewCopyPermutePass still retraces after each moved transform for metadata safety, but defers horizontal/vertical cleanup until full scan finds no more direct propagation moves. Preserves fixed-point behavior while avoiding expensive cleanup after every single moved transform.

Behavior-preserving speedup, all existing pass tests pass.

Differential Revision: D114224762

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Summary:
Speed up permute propagation cleanup.

ARM lowering spends significant time in permute propagation. Reduce avoidable repeated work while keeping same optimizations:
- Canonicalize view/permute chain collection now uses deque + membership set instead of list pop(0) and remove(), avoiding quadratic bookkeeping.
- FuseDuplicateUsersPass deduplicates pending producer revisits while preserving same revisit behavior after fusions.
- PropagateViewCopyPermutePass still retraces after each moved transform for metadata safety, but defers horizontal/vertical cleanup until full scan finds no more direct propagation moves. Preserves fixed-point behavior while avoiding expensive cleanup after every single moved transform.

Behavior-preserving speedup, all existing pass tests pass.

Differential Revision: D114224762
@apullin
apullin requested a review from digantdesai as a code owner August 25, 2026 21:14
@pytorch-bot

pytorch-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22161

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 1 Unclassified Failure

As of commit 858c82b with merge base 469debd (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2026
@meta-codesync

meta-codesync Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@apullin has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114224762.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant