Skip to content

Preserve BF16 in custom SDPA - #22160

Open
JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:export-D117220344
Open

Preserve BF16 in custom SDPA#22160
JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:export-D117220344

Conversation

@JakeStevens

Copy link
Copy Markdown
Contributor

Summary: Run llama.custom_sdpa directly for FP32 and BF16 inputs, retaining FP32 conversion only as a fallback for unsupported dtypes.

Differential Revision: D117220344

Summary: Run `llama.custom_sdpa` directly for FP32 and BF16 inputs, retaining FP32 conversion only as a fallback for unsupported dtypes.

Differential Revision: D117220344
@pytorch-bot

pytorch-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22160

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit bcc2552 with merge base 69a3979 (image):

NEW FAILURES - The following jobs have failed:

  • Cadence Build & Test / hifi-build / hifi4 (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2026
@meta-codesync

meta-codesync Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117220344.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Aug 25, 2026
Summary:

Run `llama.custom_sdpa` directly for FP32 and BF16 inputs, retaining FP32 conversion only as a fallback for unsupported dtypes.

Differential Revision: D117220344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant