Skip to content

Remove pass-local ExportPass replays (#22156) - #22156

Merged
meta-codesync[bot] merged 1 commit into
mainfrom
export-D115500386
Aug 27, 2026
Merged

Remove pass-local ExportPass replays (#22156)#22156
meta-codesync[bot] merged 1 commit into
mainfrom
export-D115500386

Conversation

@mcremon-meta

@mcremon-meta mcremon-meta commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • replace six pass-local blank ExportPass replays with local metadata ownership
  • preserve GraphModule/graph identity and unchanged no-op behavior
  • recompute bounded metadata frontiers for rewired Helios and Cadence chains
  • keep fbcode/xplat mirrors synchronized

Performance:
Avoids one whole-graph replay per modified pass, estimated at roughly 0.4-0.75 ms per graph node (about 4-8 ms for 10 nodes, 40-75 ms for 100 nodes, and 0.4-0.75 s for 1,000 nodes).

Reviewed By: ethansfng

Differential Revision: D115500386

@pytorch-bot

pytorch-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22156

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 1 Unrelated Failure

As of commit 445bd6f with merge base f6f3f42 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2026
@meta-codesync

meta-codesync Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115500386.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync Bot changed the title Remove pass-local ExportPass replays Remove pass-local ExportPass replays (#22156) Aug 26, 2026
meta-codesync Bot pushed a commit that referenced this pull request Aug 26, 2026
Summary:

- replace six pass-local blank `ExportPass` replays with local metadata ownership
- preserve `GraphModule`/graph identity and unchanged no-op behavior
- recompute bounded metadata frontiers for rewired Helios and Cadence chains
- keep fbcode/xplat mirrors synchronized

Performance:
Avoids one whole-graph replay per modified pass, estimated at roughly 0.4-0.75 ms per graph node (about 4-8 ms for 10 nodes, 40-75 ms for 100 nodes, and 0.4-0.75 s for 1,000 nodes).

Reviewed By: ethansfng

Differential Revision: D115500386
@meta-codesync
meta-codesync Bot force-pushed the export-D115500386 branch from a03202a to 42e24cf Compare August 26, 2026 16:02
Summary:

- replace six pass-local blank `ExportPass` replays with local metadata ownership
- preserve `GraphModule`/graph identity and unchanged no-op behavior
- recompute bounded metadata frontiers for rewired Helios and Cadence chains
- keep fbcode/xplat mirrors synchronized

Performance:
Avoids one whole-graph replay per modified pass, estimated at roughly 0.4-0.75 ms per graph node (about 4-8 ms for 10 nodes, 40-75 ms for 100 nodes, and 0.4-0.75 s for 1,000 nodes).

Reviewed By: ethansfng

Differential Revision: D115500386
@meta-codesync
meta-codesync Bot merged commit 6e6477d into main Aug 27, 2026
196 of 199 checks passed
@meta-codesync
meta-codesync Bot deleted the export-D115500386 branch August 27, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants