gh-151461: Fix encoding-related exception handling in file tokenizer#151462
Open
johnslavik wants to merge 9 commits into
Open
gh-151461: Fix encoding-related exception handling in file tokenizer#151462johnslavik wants to merge 9 commits into
johnslavik wants to merge 9 commits into
Conversation
johnslavik
added
needs backport to 3.14
johnslavik
changed the title
…PyTokenizer_init_error`
serhiy-storchaka
approved these changes
Jun 14, 2026
| self.assertIn(line.encode(), err) | ||
|
|
||
| def test_coding_spec_unknown_encoding(self): | ||
| src = (b'# coding: dict-unpacking-at-home\n' |
Member
There was a problem hiding this comment.
Why use such bizarre name?
|
|
||
| def test_coding_spec_unknown_encoding(self): | ||
| src = (b'# coding: dict-unpacking-at-home\n' | ||
| b'{foo} = {"foo": "bar"}\n') |
Member
There was a problem hiding this comment.
This is not even valid syntax.
Member
There was a problem hiding this comment.
While we are here, it would be nice to add also test for non-text encoding, like "hex_codec" or "rot13" (or both).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.