ci: build the docs on PRs that change the Makefile; pin syft - #34
Merged
Merged
Conversation
docs.yml runs `make docs` since #32, so a PR that changes only that target should build the site. Pin syft in mise.toml to the minor version download-syft installs in CI (v1.51.1) instead of "latest". Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Two follow-ups from #32:
docs.ymlnow also runs on PRs that change theMakefile. Since ci: add 'make ci' to run the pull-request checks locally #32 the docs job runsmake docs, so a PR that changes only that target should still build the site. Thepushpaths are unchanged: a Makefile change onmaindoesn't need a redeploy.mise.tomlto1.51, the minor versiondownload-syft(sbom-action v0.24.2) installs in CI (v1.51.1), instead of"latest". Every other tool there is pinned the same way.How was this tested?
internal/dotsync/dotsync_test.go): not applicable, workflow and tool config onlywebsite/src/content/docs/updated if behavior changed: no behavior changemise installinstalls syft 1.51.1, andmake snapshotthen passes (it failed before #32 for lack of syft).make actionlintpasses on the edited workflow.🤖 Generated with Claude Code