Repository navigation
Agents: fix joining (broken create_direct_conversation), full rollback (0.7.1) - #296
Merged
Merged
Conversation
…(0.7.1) create_direct_conversation() inserts the creator as a participant after a trigger already did, so it always failed on the unique key and agent joins rolled back. Insert the conversation and upsert both participants instead. The rollback now also deletes the users row (deleting the auth user does not cascade), its trigger-made note-to-self, the key and the conversation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan13 finding(s) MEDIUM: 9 | LOW: 4
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live test of agent joining failed with "Could not open the conversation".
create_direct_conversation()inserts the creator as a participant after theauto_add_conversation_creatortrigger already did, so it always hits the unique key. Nothing else had ever called it. Redemption now inserts the conversation and upserts both participants.The rollback also missed the
public.usersrow, because deleting the auth user doesn't cascade. It now deletes the users row, its trigger-made note-to-self, the key and the conversation. The orphan from the failed test was removed by hand.Tests: agent tests updated (no RPC; rollback deletes the users row).
🤖 Generated with Claude Code