Repository navigation
Accept Bearer tokens on the seven cookie-only API routes (0.5.3) - #286
Merged
Merged
Conversation
qc send failed with 'Unauthorized': it reads participants from /api/chat/conversations/[id]/participants and public keys from /api/crypto/public-keys, and both parsed only cookies. Same for chat/messages, chat/messages/[id], public-keys/all and the disappearing-messages routes. They now take Authorization: Bearer first (shared bearerToken()), cookies after, which also covers cookie-less passkey and CoinPay browser sessions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan13 finding(s) MEDIUM: 9 | LOW: 4
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qc sendfailed with "Not sent: Unauthorized". Before sending, qc reads/api/chat/conversations/[id]/participantsand/api/crypto/public-keys, and both had their own cookie-only auth.An audit found seven such routes: participants,
chat/messages,chat/messages/[id],crypto/public-keys,crypto/public-keys/all, and both disappearing-messages routes. Each now checksAuthorization: Bearerfirst, through a sharedbearerToken(), then falls back to cookies as before. This also fixes cookie-less passkey and CoinPay browser sessions on those routes.Tests: 670/670, including a new test for Bearer with no cookie.
next buildpasses.🤖 Generated with Claude Code