Repository navigation
qc keeps keys and tokens sealed at rest (qc 0.3.0) - #280
Merged
Merged
Conversation
session.json was plaintext (mode 0600 only): both private ML-KEM keys and the refresh token readable by anything that could read the file. It is now v2: only the server and who you are stay open (qc whoami); tokens and keypairs are sealed with ChaCha20-Poly1305 under a 32-byte key from QC_PASSPHRASE (scrypt), the OS keychain (macOS Keychain or secret-tool), or a passphrase asked once per run. Refreshed tokens are re-sealed under the same key. A v1 file is sealed on first use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan13 finding(s) MEDIUM: 9 | LOW: 4
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
~/.config/qc/session.jsonwas plaintext, protected only by file mode 0600. Both private ML-KEM keypairs and the refresh token were readable by anything that could read that file.Fix: the session file is now v2.
qc whoamistill works without unlocking.QC_PASSPHRASE, stretched with scrypt (N=65536, r=8, p=1), for scripts andqc mcpsecret-tool), so a desktop never asksTests: 6 new tests covering round-trip, wrong passphrase, re-seal, v1 upgrade, keychain use with no prompt, and passphrase confirmation.
test:ci: 642/642.🤖 Generated with Claude Code