Repository navigation
fix(setup): stop the drafted profile from being unsavable - #30
Merged
Merged
Conversation
Reading a site produced a profile the save then rejected as "that profile is incomplete". The cause: every list in the profile contract capped an entry at 120 characters, which is right for a job title and wrong for a value proposition — the model writes those as sentences, and one line of 132 characters failed the whole PUT. There was no way out of it from the page, because valuePropositions had no input on the form and the error named no field. Three changes so it cannot recur: - The contract distinguishes terms (120) from sentences (300). ICP facets and competitors stay terms; value propositions, pains and exclusions are sentences. Limits are exported so there is one source of truth. - The drafter clamps every field to those limits on a word boundary, so a chatty model produces a shorter draft rather than an unsavable one. - The rejection is keyed by full path (`offering.valuePropositions.3`) instead of by top-level object, the web form shows it next to the save button rather than off-screen by the URL box, and value propositions are editable like everything else that gets saved. Verified against the payload that failed on production: it now validates. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
/setupread the site, drafted a profile, and then refused to save it: "that profile is incomplete".Every list in
workspaceProfileSchemacapped an entry at 120 characters. That is the right length for a job title and the wrong length for a value proposition — the model writes those as sentences. Reproduced on production againstprofullstack.com, whose draft came back with one 132-character value proposition:It was a dead end, not an inconvenience:
valuePropositionshad no input on the form, so the offending line could not be shortened, and the error namedoffering— not which of its six fields, or which line of it.What changed
profileLimitsso the drafter and the schema cannot drift.…. A chatty model now yields a shorter draft rather than an unsavable one — a draft the contract refuses must not be reachable.offering.valuePropositions.3), shown next to the save button instead of off-screen by the URL box, and value propositions are editable like everything else that gets saved.Verification
POSTreturns must be acceptable toPUTuntouched.bun run checkgreen — format, typecheck, 550 tests;apps/webtypechecks clean.🤖 Generated with Claude Code