Repository navigation
test(thetvdb): pin the clock so the fixture token cannot expire - #191
Merged
Merged
Conversation
The fixture JWT expires 2026-10-13T18:15:21Z and the adapter renews a token within a day of expiry, so three tests began failing on main once that day arrived. Pin Date with bun:test setSystemTime before each test, derive FRESH from the pinned time, and advance the clock instead of sleeping where a later timestamp is asserted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI `test` job fails on main (and every PR, e.g. #190) in `test/screen-thetvdb-catalog.test.js`: the fixture JWT expires 2026-10-13T18:15:21Z and the adapter renews a token within a day of its expiry, so three tests now see an unexpected login.
Locally: file 18/18 pass; full suite 2356 pass, 0 fail; lint clean (warnings unchanged).
🤖 Generated with Claude Code