fix(ads): ad hero images off gpt-image-1 before Oct 23 shutdown (#346)

[ralyodio]

gpt-image-1 shuts down 2026-10-23. Ad hero images (lib/ads/heroImage.ts) now use gpt-image-2.5-sunburst, the replacement OpenAI lists. Without this the hero silently falls back to og:image / tinted wash after the 23rd.

Verified: tsc clean; vitest 2753 pass, 4 fail (ads gif/video ffmpeg tests, same 4 fail on master locally); the exact request (1536x1024, medium) returned 200 with b64_json using the prod key.

lib/lx/articleGen.ts and lib/sp/imageGen.ts already use gpt-image-2 (not deprecated).

Closes #346

🤖 Generated with Claude Code

[github-actions]

ThreatCrush Security Scan

48 finding(s)

HIGH/CRITICAL: 2 | MEDIUM: 31 | LOW: 15

Severity	Rule	Location
HIGH	tls-verification-disabled	lib/onion.ts:48
HIGH	secret-generic-credential	lib/sp/platforms/facebook.ts:32
MEDIUM	js-unescaped-html-sink	app/(app)/dashboard/admin/email-broadcast/EmailBroadcastForm.tsx:125
MEDIUM	js-unescaped-html-sink	app/(app)/dashboard/projects/[id]/autoblog/articles/[articleId]/page.tsx:214
MEDIUM	js-unescaped-html-sink	app/(marketing)/blog/[slug]/page.tsx:67
MEDIUM	js-unescaped-html-sink	app/(marketing)/blog/[slug]/page.tsx:97
MEDIUM	js-unescaped-html-sink	app/(marketing)/blog/[slug]/page.tsx:104
MEDIUM	js-unescaped-html-sink	app/(marketing)/blog/[slug]/page.tsx:110
MEDIUM	js-unescaped-html-sink	app/(marketing)/recent/page.tsx:186
MEDIUM	js-unescaped-html-sink	app/(marketing)/recent/page.tsx:190
MEDIUM	js-unescaped-html-sink	app/c/[project]/[slug]/page.tsx:77
MEDIUM	js-unescaped-html-sink	app/c/[project]/page.tsx:57
MEDIUM	js-unescaped-html-sink	app/careers.js/route.ts:228
MEDIUM	js-unescaped-html-sink	app/careers.js/route.ts:285
MEDIUM	js-unescaped-html-sink	app/layout.tsx:128
MEDIUM	js-open-redirect	app/login/form.tsx:39
MEDIUM	js-unescaped-html-sink	app/r/[token]/page.tsx:176
MEDIUM	js-open-redirect	app/signup/form.tsx:43
MEDIUM	js-open-redirect	components/billing/buy-credits-modal.tsx:98
MEDIUM	js-unescaped-html-sink	components/json-ld.tsx:8
MEDIUM	js-unescaped-html-sink	components/report/markdown-view.tsx:15
MEDIUM	js-unescaped-html-sink	lib/careers/page-templates.ts:198
MEDIUM	js-dynamic-code-execution	lib/crawl-limits.ts:67
MEDIUM	redos-nested-quantifier	lib/emailMarkdown.ts:41
MEDIUM	redos-nested-quantifier	lib/emailMarkdown.ts:324
MEDIUM	redos-nested-quantifier	lib/lx/articleGen.ts:100
MEDIUM	redos-nested-quantifier	lib/tracker/agent-gate.ts:61
MEDIUM	sh-predictable-temp-path	ops/selfhost/server/setup-supabase.sh:218
MEDIUM	sql-template-interpolation	scripts/detect-slot-themes.ts:31
MEDIUM	sql-template-interpolation	scripts/purge-constructed-keywords.ts:163
MEDIUM	sql-template-interpolation	scripts/purge-offniche-keywords.ts:124
MEDIUM	js-dynamic-code-execution	scripts/test-crawl-limits.mjs:14
MEDIUM	js-dynamic-code-execution	scripts/test-crawl-limits.mjs:24
LOW	secret-generic-credential	app/(marketing)/docs/autoblog-webhook/page.tsx:145
LOW	secret-generic-credential	lib/sp/platforms/linkedin.ts:25
LOW	js-dynamic-code-execution	tests/careers-page-templates.test.ts:21
LOW	js-dynamic-code-execution	tests/careers-widget-script.test.ts:19
LOW	js-dynamic-code-execution	tests/careers-widget-script.test.ts:69
LOW	js-dynamic-code-execution	tests/contract/ad-visitor-id.test.ts:51
LOW	js-dynamic-code-execution	tests/contract/ad-visitor-id.test.ts:52
LOW	js-dynamic-code-execution	tests/contract/ads-click-cooldown-redis.test.ts:20
LOW	js-dynamic-code-execution	tests/contract/ads-click-cooldown-redis.test.ts:24
LOW	js-dynamic-code-execution	tests/contract/ads-click-cooldown-redis.test.ts:25
LOW	js-dynamic-code-execution	tests/contract/ads-click-cooldown-redis.test.ts:26
LOW	js-dynamic-code-execution	tests/contract/ads-click-cooldown-redis.test.ts:31
LOW	js-dynamic-code-execution	tests/contract/ads-click-cooldown-redis.test.ts:35
LOW	secret-generic-credential	tests/contract/posthog-integration.test.ts:13
LOW	secret-generic-credential	tests/lead-campaign.test.ts:16

Snippets are redacted; ThreatCrush never prints matched credential material.