Skip to content

fix: update enforce-workflow job to allow PR merges - #34

Merged
ishaileshpant merged 1 commit into
mainfrom
fix/enforce-workflow-job
Sep 26, 2025
Merged

ishaileshpant merged 1 commit into
mainfrom
fix/enforce-workflow-job

Conversation

@ishaileshpant

Copy link
Copy Markdown
Collaborator

🚨 Critical Fix: Complete Branch Protection Workflow

The GitHub Actions run was still failing because there were TWO jobs blocking PR merges:

  1. job (already fixed)
  2. job (still blocking)

❌ Problem:

  • The job was still blocking ALL pushes to main
  • PR merges were being blocked by this second job
  • GitHub Actions failing after PR merges

✅ Solution:

  • Updated the job with the same logic as
  • Both jobs now detect PR merges vs direct pushes
  • Allows legitimate PR merges while blocking direct pushes
  • Complete fix for the branch protection system

📋 Changes:

  • Fixed job to allow PR merges
  • Added commit message detection logic
  • Both jobs now work consistently
  • Complete branch protection workflow fix

This completes the fix for the branch protection system.

- Fixed the enforce-workflow job that was also blocking PR merges
- Added same logic to detect PR merges vs direct pushes
- Both protect-main and enforce-workflow jobs now allow legitimate PR merges
- Still blocks direct pushes to main branch
@ishaileshpant ishaileshpant self-assigned this Sep 26, 2025
@ishaileshpant
ishaileshpant merged commit 28b1af7 into main Sep 26, 2025
11 checks passed
@vercel

vercel Bot commented Sep 26, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
prepguides-dev Ready Ready Preview Comment Sep 26, 2025 6:10pm

@ishaileshpant
ishaileshpant deleted the fix/enforce-workflow-job branch September 26, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant