Fix GitHub App detection logic to use bot API instead of fallback - #120
Merged
Merged
Conversation
- Remove GITHUB_APP_INSTALLATION_ID requirement from configuration check - Add dynamic installation ID lookup for prepguides organization - Ensure bot API uses GitHub App instead of falling back to user token method - Resolves FUNCTION_INVOCATION_FAILED by properly detecting GitHub App configuration The issue was that the code was still checking for GITHUB_APP_INSTALLATION_ID as a required environment variable, causing it to fall back to the user token method instead of using the configured GitHub App. This fix allows the bot to work with just GITHUB_APP_ID and GITHUB_APP_PRIVATE_KEY, then dynamically finds the installation ID for the prepguides organization.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
/approve |
Contributor
|
🚀 Admin-Approved and Auto-Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Fix GitHub App Detection Logic
Problem
The bot API was still failing with "FUNCTION_INVOCATION_FAILED" error because it was incorrectly falling back to the user token method instead of using the configured GitHub App.
Root Cause
The code was still checking for
GITHUB_APP_INSTALLATION_IDas a required environment variable, causing it to fall back to the user token method instead of using the GitHub App that's already configured in Vercel.Solution
Technical Changes
How It Works
Files Changed
api/github/create-content-pr.js- Fixed GitHub App detection and initialization logicImpact
Testing