Skip to content

Fix GitHub App configuration detection and dynamic installation ID lookup #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ishaileshpant wants to merge 1 commit into from
Closed

Fix GitHub App configuration detection and dynamic installation ID lookup #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 37 additions & 7 deletions api/github/create-content-pr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ export default async function handler(req, res) {
}

// Check if GitHub App is configured
if (!process.env.GITHUB_APP_ID || !process.env.GITHUB_APP_PRIVATE_KEY || !process.env.GITHUB_APP_INSTALLATION_ID) {
console.log('GitHub App not configured');
if (!process.env.GITHUB_APP_ID || !process.env.GITHUB_APP_PRIVATE_KEY) {
console.log('GitHub App not configured - missing GITHUB_APP_ID or GITHUB_APP_PRIVATE_KEY');
return res.status(503).json({
error: 'GitHub App not configured',
message: 'Please set up GITHUB_APP_ID, GITHUB_APP_PRIVATE_KEY, and GITHUB_APP_INSTALLATION_ID environment variables',
message: 'Please set up GITHUB_APP_ID and GITHUB_APP_PRIVATE_KEY environment variables',
configured: false
});
}
Expand All @@ -48,22 +48,52 @@ export default async function handler(req, res) {
try {
console.log('🔧 Initializing GitHub App...');
console.log('App ID:', process.env.GITHUB_APP_ID);
console.log('Installation ID:', process.env.GITHUB_APP_INSTALLATION_ID);
console.log('Private Key length:', process.env.GITHUB_APP_PRIVATE_KEY?.length);

// First, create auth without installation ID to get app token
const appAuth = createAppAuth({
appId: process.env.GITHUB_APP_ID,
privateKey: process.env.GITHUB_APP_PRIVATE_KEY.replace(/\\n/g, '\n'),
});

// Get app token to find installations
const appToken = await appAuth({ type: 'app' });
const tempOctokit = new Octokit({ auth: appToken.token });

// Find installation for the target repository
const installations = await tempOctokit.apps.listInstallations();
console.log('Found installations:', installations.data.length);

let installationId = process.env.GITHUB_APP_INSTALLATION_ID; // Use env var if available

if (!installationId) {
// Find installation for prepguides/prepguides.dev
const targetInstallation = installations.data.find(installation =>
installation.account.login === 'prepguides'
);

if (targetInstallation) {
installationId = targetInstallation.id;
console.log('Found installation ID:', installationId);
} else {
throw new Error('No installation found for prepguides organization');
}
}

// Create auth with installation ID
const auth = createAppAuth({
appId: process.env.GITHUB_APP_ID,
privateKey: process.env.GITHUB_APP_PRIVATE_KEY.replace(/\\n/g, '\n'),
installationId: process.env.GITHUB_APP_INSTALLATION_ID,
installationId: installationId,
});

octokit = new Octokit({ auth });
console.log('✅ GitHub App initialized successfully');
console.log('✅ GitHub App initialized successfully with installation ID:', installationId);
} catch (appError) {
console.error('❌ GitHub App initialization error:', appError);
return res.status(500).json({
error: 'GitHub App initialization failed',
message: 'Failed to initialize GitHub App. Please check your environment variables.',
message: 'Failed to initialize GitHub App. Please check your environment variables and app installation.',
details: process.env.NODE_ENV === 'development' ? appError.message : undefined
});
}
Expand Down