Skip to content

Revert OAuth changes from PR #112 - restore working authentication #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 2 commits into from
Oct 8, 2025
Merged

Revert OAuth changes from PR #112 - restore working authentication #115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
975078f
Revert "Admin-approved merge: Fix OAuth authentication: Add missing r…
ishaileshpant Oct 8, 2025
83a881e
Resolve merge conflicts in revert PR
ishaileshpant Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 4 additions & 24 deletions github-auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ class GitHubAuth {
async processOAuthCode(code, state) {
try {
console.log('Processing OAuth code:', code);
console.log('OAuth state:', state);
console.log('Current URL:', window.location.href);

// Process the OAuth callback
const response = await fetch('/api/auth/github', {
Expand All @@ -80,17 +78,10 @@ class GitHubAuth {
});

console.log('OAuth response status:', response.status);
console.log('OAuth response headers:', Object.fromEntries(response.headers.entries()));

if (!response.ok) {
const errorData = await response.json();
console.error('OAuth error response:', errorData);

// Handle specific OAuth errors
if (errorData.message && errorData.message.includes('incorrect or expired')) {
throw new Error('OAuth code has expired. Please try logging in again.');
}

throw new Error(errorData.message || 'Authentication failed');
}

Expand Down Expand Up @@ -215,21 +206,10 @@ class GitHubAuth {
}

// For now, let's use a simple approach - redirect to GitHub and handle the callback manually
const redirectUri = this.getCallbackUri();
const state = this.generateState();

// Build URL parameters properly
const params = new URLSearchParams({
client_id: this.clientId,
scope: this.scope,
state: state,
redirect_uri: redirectUri
});

const authUrl = `https://github.com/login/oauth/authorize?${params.toString()}`;

console.log('OAuth redirect URI:', redirectUri);
console.log('OAuth auth URL:', authUrl);
const authUrl = `https://github.com/login/oauth/authorize?` +
`client_id=${this.clientId}&` +
`scope=${this.scope}&` +
`state=${this.generateState()}`;

// Store that we're in the middle of OAuth
localStorage.setItem('oauth_in_progress', 'true');
Expand Down