Repository navigation
Send chemked-ingest to kineticmodelssite after merges to master - #44
Open
LekiaAnonim wants to merge 1 commit into
Open
LekiaAnonim wants to merge 1 commit into
LekiaAnonim wants to merge 1 commit into
Conversation
"git diff-tree HEAD" prints nothing for a merge commit, and pull requests into master are merged with merge commits (for example 606005b, PR pr-omethe-us#33), so the workflow found no files and sent no dispatch. It also saw only the last commit of a push with several commits. - Diff github.event.before..HEAD (first parent if "before" is unknown) with full history. - Build the dispatch body with jq, so quotes in file names cannot break the JSON. - curl --fail-with-body, so a rejected dispatch (bad token, wrong repo) fails the job.
LekiaAnonim
force-pushed
the
ci/ingest-on-merge
branch
from
October 22, 2026 15:13
1bd44d7 to
61e7017
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
.github/workflows/ingest-on-merge.ymltomasterso kineticmodelssite is told to ingest merged ChemKED contribution files, and fixes how the workflow finds the merged files. It now comparesgithub.event.beforewithHEAD(the first parent ifbeforeis unknown), with full history.jq, so quotes in file names cannot break the JSON.curl --fail-with-bodymakes a rejected dispatch (bad token, wrong repository) fail the job.Needed before it works end to end
DISPATCH_TOKEN: it must be allowed to send repository dispatches tokineticmodelssite(validate-contribution.ymlalready uses this secret).chemked-ingest.ymlfix (companion PR) on its default branch, andCHEMKED_DATABASE_PATHin the runner'skms.env, pointing to a clone of this repository onmaster.How it was checked
n-pentane_NOxfiles. A README-only merge gives[].jqfor paths with spaces and quotes; the JSON is valid..github/changes.