fix(components): resolve gallery preview URLs against the site root - #484
Merged
Merged
Conversation
Quarto rewrites an img's src to a relative path but leaves data-* attributes site-root absolute, so the hover GIF was fetched from /components/... instead of /py/components/... in production (404) and the poster broke on pointerleave.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hover GIFs on https://shiny.posit.co/py/components/ never played.
Quarto rewrites an
<img>'ssrcto a relative path, but leavesdata-*attributes site-root absolute.data-animated-src="/components/…/preview.gif"was fetched fromshiny.posit.co/components/…(404, missing/py). The script's catch fell back to the thumbnail silently. The same bug also set the thumbnail back to a broken URL on pointerleave.Fix: resolve both
data-*paths against Quarto's<meta name="quarto:offset">, so it works under/pyin prod and at the root on Netlify previews.Verified against prod with the patched script injected: GIF request →
/py/components/inputs/action-button/preview.gif200, card plays, poster restores on leave.