feat: escape HTML - #881
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
==========================================
- Coverage 98.83% 98.71% -0.12%
==========================================
Files 51 51
Lines 7696 7718 +22
==========================================
+ Hits 7606 7619 +13
- Misses 90 99 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds HTML-escaping of unformatted body cells whenever a table is rendered as HTML. This is whether the table is displayed in a notebook, shown via
show(), or exported withas_raw_html(). Previously, only LaTeX output escaped unformatted cells but this change extends that to all output contexts.Cells processed by any
fmt_*()method are treated as trusted and pass through unchanged. The escaping also covers group labels (when derived from rawgroup_idrather than a formattedgroup_label) and summary stub labels.A new
fmt_passthrough()method gives users explicit control:escape=True(default) escapes special characters,escape=Falsepasses raw HTML/LaTeX through, andpattern=decorates values without transforming them.