Align PHP requirement with CI matrix (Copilot feedback)#25
Closed
slashrsm wants to merge 3 commits into
Closed
Conversation
Addresses Copilot review on portphp#24: composer declared php >=5.6 while CI only exercises 8.2–8.5. Raise the runtime constraint to match tested versions, and harden composer validate/cache key handling.
There was a problem hiding this comment.
Pull request overview
This PR aligns the package’s declared PHP support and CI behavior with the current GitHub Actions test matrix (PHP 8.2–8.5), addressing prior review feedback from #24.
Changes:
- Raised the Composer PHP platform requirement to
>=8.2to match the CI matrix. - Updated CI to validate
composer.lockonly when it exists, keeping--no-check-lockfor repos without a lockfile. - Included
composer.lock(when present) in the Composer cache key hash to better invalidate caches when dependency state changes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| composer.json | Updates declared PHP requirement to >=8.2 to match CI-supported versions. |
| .github/workflows/checks.yml | Improves Composer validation behavior around lockfiles and updates cache key hashing to account for composer.lock when present. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Use ^8.2 instead of >=8.2 so Composer does not accept PHP 9+ by default - Prefer composer install when a lockfile is present
- Pass --no-interaction on composer validate/install/update - Rename validate step to reflect lockfile handling
Contributor
Author
|
Merged to master via git squash (gh OAuth lacks workflow scope for PR merge API). |
slashrsm
added a commit
that referenced
this pull request
Jul 22, 2026
Raise php to ^8.2, lock-aware composer validate/install, cache key includes lock, --no-interaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #24 addressing Copilot review feedback.
phprequirement from>=5.6.0to^8.2so declared support matches the CI matrix (and does not auto-accept PHP 9+)composer.lockwhen present; keep--no-check-lockonly when missingcomposer installwhen a lockfile is presentcomposer.lockin the Actions cache key hash--no-interactionTest plan