Release 2.0.0: PHP ^8.2, portphp ^2.0, GitHub Actions#4
Merged
Conversation
Breaking major: drop PHP < 8.2 and portphp 1.x. Replace Travis with GHA, Dependabot, modern README.
There was a problem hiding this comment.
Pull request overview
This PR modernizes the Port PDO adapter for a 2.0.0 release by raising the minimum supported PHP version, updating dependencies to current major versions, and migrating CI/configuration from legacy services to GitHub Actions.
Changes:
- Bump platform/runtime requirements to PHP
^8.2andportphp/portphp^2.0. - Migrate CI from Travis/Scrutinizer to GitHub Actions and add Dependabot configuration.
- Update PHPUnit configuration/tests and refresh project documentation/metadata.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| UPGRADE-2.0.md | Adds an upgrade note summarizing the breaking requirement changes and CI migration. |
| tests/PdoWriterTest.php | Updates PHPUnit base class and setup signature for PHPUnit 9 compatibility. |
| tests/PdoReaderTest.php | Updates PHPUnit base class and replaces deprecated assertion API with a modern equivalent. |
| README.md | Refreshes badges/requirements/docs link and removes Travis/Scrutinizer references. |
| phpunit.xml.dist | Updates PHPUnit configuration structure/strictness settings for PHPUnit 9. |
| composer.json | Raises PHP and library constraints; updates dev dependencies to PHPUnit 9.6 and PDO SQLite extension. |
| .travis.yml | Removes legacy Travis CI configuration. |
| .scrutinizer.yml | Removes legacy Scrutinizer configuration. |
| .github/workflows/test.yml | Adds GitHub Actions test workflow for PHP 8.2–8.5. |
| .github/dependabot.yml | Adds Dependabot update configuration for Actions and Composer. |
| .gitattributes | Removes export-ignore entries for deleted CI config files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $i=1; | ||
| foreach ($this->getReader() as $row) { | ||
| $this->assertInternalType('array', $row); | ||
| $this->assertIsArray( $row); |
| <phpunit backupGlobals="false" | ||
| backupStaticAttributes="false" | ||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.5/phpunit.xsd" |
Comment on lines
34
to
38
| Contributions are very welcome. Please see [CONTRIBUTING.md](CONTRIBUTING.md) for | ||
| details. Thanks to [everyone who has contributed](https://github.com/portphp/pdo/graphs/contributors) | ||
| already. | ||
|
|
||
| ## Security | ||
|
|
||
| If you discover any security-related issues, please contact us at | ||
| [security@portphp.org](mailto:security@portphp.org). | ||
|
|
||
| ## License |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Major modernization of the PDO adapter.
Breaking
php:^8.2(was>=5.4)portphp/portphp:^2.0Other
UPGRADE-2.0.mdSame-repo branch so Actions runs without fork approval.