Avoids purging el on unmount if el is not found#302
Closed
willleahy wants to merge 1 commit into
Closed
Conversation
Fixes an issue where, when changing a route in an SPA, unmount will be called after the page changes and this.el can no longer be found.
cenkakay
approved these changes
Jan 3, 2024
Contributor
|
Thanks for your PR! I apologize that this got dusty over the years. The underlying issue has been fixed in v4 that was just released, so I'm going to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where unmount will be called after the page changes and this.el can no longer be found. In my case, this happened using react-plotly in a creat-react-app app + react-router app when the route changed away from a page using plotly.