Skip to content

CI: run on pull requests and manual dispatch; build all unit tests in CMake - #130

Merged
emeryberger merged 1 commit into
masterfrom
ci/pr-triggers-cmake-tests
Oct 20, 2026
Merged

emeryberger merged 1 commit into
masterfrom
ci/pr-triggers-cmake-tests

Conversation

@emeryberger

Copy link
Copy Markdown
Member

Summary

  • Workflow triggers: CI only ran on `push`, so PRs from forks (e.g. Fix backing-file offset truncation at 4 GiB #129) never got CI, and there was no way to re-run CI on a commit once its last run was older than 30 days. Adds `pull_request` and `workflow_dispatch` triggers.
  • CMake test list: `src/CMakeLists.txt` listed the unit test files by hand and was missing `cacheline_padding_test.cc` and `fork_test.cc`, so the CMake job ran 35 tests while Bazel's glob ran 50 on Linux.

Testing

  • CI on this branch (run 39331988088): all three jobs pass. Ubuntu_cmake now runs 50 tests, the same as Ubuntu_bazel.
  • Local CMake build on macOS (arm64): 53/53 tests pass, the same as Bazel.

Notes

  • PRs from branches in this repo will now run CI twice (once for `push`, once for `pull_request`). That's harmless, just extra runner time.
  • Not fixed here: the CMake build fails with `make -j`, because the sources don't declare a dependency on the Heap-Layers download. CI builds serially, so it isn't affected.

🤖 Generated with Claude Code

… CMake

The workflow only triggered on push, so PRs from forks never ran CI and
old runs could not be re-run once they aged out. Add pull_request and
workflow_dispatch triggers.

The CMake unit-test list was missing cacheline_padding_test.cc and
fork_test.cc, so the CMake job ran fewer tests than Bazel's glob.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@emeryberger
emeryberger merged commit a9826eb into master Oct 20, 2026
7 checks passed
@emeryberger
emeryberger deleted the ci/pr-triggers-cmake-tests branch October 20, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant