Skip to content

docs: restore v8.5 Top SQL multidimensional docs for v8.5.7#23062

Open
yibin87 wants to merge 3 commits into
release-8.5from
restore-v8.5.7-topsql-multidimensional
Open

docs: restore v8.5 Top SQL multidimensional docs for v8.5.7#23062
yibin87 wants to merge 3 commits into
release-8.5from
restore-v8.5.7-topsql-multidimensional

Conversation

@yibin87

@yibin87 yibin87 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

  • Restore the Top SQL multidimensional guidance in dashboard/top-sql.md for the release-8.5 branch after the feature is enabled in v8.5.7.
  • Restore the resource-metering.enable-network-io-collection configuration reference in tikv-configuration-file.md.
  • Update the restored version markers and anchor references to indicate availability starting from v8.5.7 in the v8.5 docs.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for the TiDB Dashboard Top SQL page and the TiKV configuration file to introduce the new TiKV Network I/O collection feature in v8.5.7, which enables tracking network traffic and logical I/O metrics. The reviewer's feedback focuses on improving clarity, readability, and style guide compliance. Key suggestions include consistently using "I/O" instead of "IO", applying sentence case to headings, preferring active voice and present tense, simplifying sentence structures, and correcting prepositions.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread dashboard/top-sql.md Outdated
Comment thread dashboard/top-sql.md Outdated
Comment thread dashboard/top-sql.md
Comment thread dashboard/top-sql.md Outdated
Comment thread dashboard/top-sql.md
Comment thread dashboard/top-sql.md
Comment thread tikv-configuration-file.md
Comment thread tikv-configuration-file.md
Comment thread tikv-configuration-file.md
Comment thread tikv-configuration-file.md
@qiancai qiancai added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Jun 16, 2026
@qiancai qiancai self-assigned this Jun 16, 2026
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ti-chi-bot

ti-chi-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 16, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-06-16 09:10:30.40705478 +0000 UTC m=+1469531.477372160: ☑️ agreed by qiancai.

@qiancai qiancai added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants