Skip to content

[diffs/edit] Fix soft-wrap vertical caret motion#996

Merged
ije merged 2 commits into
beta-1.3from
ije/fix-soft-wrapd
Jul 15, 2026
Merged

[diffs/edit] Fix soft-wrap vertical caret motion#996
ije merged 2 commits into
beta-1.3from
ije/fix-soft-wrapd

Conversation

@ije

@ije ije commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Soft-wrap vertical motion splits surrogate pairs (2) — vertical motion
into a wrapped continuation row computes the landing spot as raw UTF-16 units
with no grapheme/surrogate snapping, so moving down into a continuation row
(or up across a logical-line boundary) can park the caret between the halves
of an astral character; a subsequent insert there splits the pair into lone
surrogates.

Soft-wrap vertical caret motion now snaps landing offsets to Unicode grapheme boundaries while preserving goal-column overshoot behavior.

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pierre-docs-diffs Ready Ready Preview Jul 15, 2026 3:54pm
pierre-docs-diffshub Ready Ready Preview Jul 15, 2026 3:54pm
pierre-docs-trees Ready Ready Preview Jul 15, 2026 3:54pm
pierrejs-diff-demo Ready Ready Preview Jul 15, 2026 3:54pm

Request Review

@ije

ije commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 438f6ccd85

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/diffs/src/editor/selection.ts Outdated
@ije ije merged commit 940a64f into beta-1.3 Jul 15, 2026
8 checks passed
@ije ije deleted the ije/fix-soft-wrapd branch July 15, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants