Skip to content

[diffs/edit] Normalize inverted editor selections#995

Merged
ije merged 1 commit into
beta-1.3from
ije/normalize-inverted-selections
Jul 15, 2026
Merged

[diffs/edit] Normalize inverted editor selections#995
ije merged 1 commit into
beta-1.3from
ije/normalize-inverted-selections

Conversation

@ije

@ije ije commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Inverted selection after normalization (1) — setting selections normalizes
positions but never reorders a start-after-end pair, storing an inverted
selection that violates the start-before-or-equal-end invariant downstream
code assumes.

Normalized endpoints are reordered and direction is flipped to preserve focus.

@ije ije requested review from amadeus, fat and necolas July 15, 2026 14:05
@ije

ije commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 1a944487d8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@ije ije merged commit ac1b0cf into beta-1.3 Jul 15, 2026
8 checks passed
@ije ije deleted the ije/normalize-inverted-selections branch July 15, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants