Skip to content

[codex] v0.11.1 chess benchmark hotfix - #23

Merged
mattbaconz merged 1 commit into
mainfrom
codex/v0.11.1-quality-token-hotfix
May 11, 2026
Merged

mattbaconz merged 1 commit into
mainfrom
codex/v0.11.1-quality-token-hotfix

Conversation

@mattbaconz

Copy link
Copy Markdown
Contributor

Summary

  • recognize chess symbol/abbreviation piece maps in quality gates
  • skip automatic broad chess quality repair after already-expensive attempts and surface an explicit retry hint
  • honor explicit empty-workspace HTML chess goals with an index.html contract
  • bump release metadata to v0.11.1

Validation

  • cargo fmt --all -- --check
  • cargo test --locked --workspace
  • cargo clippy --locked --workspace --all-targets -- -D warnings
  • cargo build --release --locked -p phonton-cli
  • target\release\phonton.exe version
  • target\release\phonton.exe --help
  • npm run test:npm-wrapper
  • npm pack --dry-run

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1b807f376f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

let quality_failures = self.quality_gate_failures(&plan, &runtimes);
if !quality_failures.is_empty()
&& quality_repair_attempts < MAX_QUALITY_REPAIR_ATTEMPTS
&& should_auto_repair_quality(&plan, tokens_used)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Gate auto-repair on non-duplicated token totals

The new should_auto_repair_quality(&plan, tokens_used) check uses the scheduler’s aggregate tokens_used, but that counter is not a pure provider-total: SubtaskProgress sets rt.tokens_used = tokens_so_far during execution and handle_completion later adds the final worker_tokens again, so runs with progress updates can be double-counted. With this change, a chess attempt that actually uses under 8k provider tokens can appear above 8k and incorrectly skip automatic quality repair, turning recoverable quality failures into hard task failures; the ceiling check should be based on non-duplicated token usage accounting.

Useful? React with 👍 / 👎.

@mattbaconz
mattbaconz merged commit 4b46898 into main May 11, 2026
1 check passed
@mattbaconz
mattbaconz deleted the codex/v0.11.1-quality-token-hotfix branch May 11, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant