Repository navigation
refactor: reorganize src/ into internal/{codec,protocol} with clear header-only vs header+cpp split - #21
Merged
Conversation
Co-authored-by: petesramek <2333452+petesramek@users.noreply.github.com> Agent-Logs-Url: https://github.com/petesramek/tiny-link/sessions/debc3c5b-0d0f-49aa-84ab-290ed948019c
petesramek
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packet,CobsCodec, andFletcher16were internal implementation details sitting at thesrc/root alongside public headers. The existingsrc/protocol/internal/nesting was also inverted —internalshould be the top-level category.Changes
src/internal/codec/— movedPacket,CobsCodec, andFletcher16(the only files with.cppimplementations) heresrc/internal/protocol/— moved wire-format headers (AckMessage,HandshakeMessage,LogMessage,Packed) fromsrc/protocol/internal/here, flattening the inverted nesting#includepaths inTinyLink.h, the moved headers,TinyProtocol.hcomments, and all test filesResulting layout
The
internal/boundary is now the single, top-level marker for implementation details, withcodec/vsprotocol/distinguishing the two internal concerns.