Skip to content

feat(local): add french langage - #1584

Merged
perber merged 4 commits into
perber:mainfrom
Hugo-Galley:feat/add-french-langage
Sep 25, 2026
Merged

perber merged 4 commits into
perber:mainfrom
Hugo-Galley:feat/add-french-langage

Conversation

@Hugo-Galley

Copy link
Copy Markdown
Contributor

Related issue

No related isssues, it's just for add french transcriptions in wiki
Fixes #

What changed

  • Add a french transcriptions

Checklist

  • I discussed the approach on the linked issue before starting (or this is a trivial fix: typo, docs, obvious one-liner)
  • This PR is focused on a single change
  • I ran npm run format in ui/leafwiki-ui (and in e2e if e2e tests changed)
  • I updated documentation if needed

@Hugo-Galley
Hugo-Galley requested a review from perber as a code owner September 22, 2026 17:25
@perber

perber commented Sep 23, 2026

Copy link
Copy Markdown
Owner

@Hugo-Galley Thanks! I was actually going to ask you about that. I’ve merged some new content. Could you update those few words?

@Hugo-Galley

Copy link
Copy Markdown
Contributor Author

Yes, I’ll take care of it.

- assets: add insertPdfLink / insertPdf keys + update tip text (pdf embed)
- viewer: add pdfEmbed.defaultTitle (pdf embed)
- backup: add path/pathPlaceholder/pathHint keys (LEAFWIKI_GIT_BACKUP_PATH)
- tocDisplay: create missing FR file (always-show TOC admin setting)
@Hugo-Galley
Hugo-Galley force-pushed the feat/add-french-langage branch from 16fc0b3 to 999614b Compare September 23, 2026 10:09
@Hugo-Galley

Copy link
Copy Markdown
Contributor Author

@perber I push new translations

- fr/backup.json used a stale secretKeepPlaceholder key instead of the
  current secretStoredLabel + changeSecretButton pair, which broke the
  i18n key-parity test (the CI failure on this PR)
- config.test.ts used 'fr' as its example of an unrecognized language,
  which no longer holds once fr ships
- internal/usersettings/language.go's allowedLanguages map was missing
  fr, so users could never actually select French as their UI language
  in settings despite the shipped translations
- normalized a few stray curly apostrophes in fr/common.json and
  fr/publicAccess.json to match the straight-quote convention used in
  the other locales
@perber
perber merged commit 6d7bc87 into perber:main Sep 25, 2026
9 checks passed
@Hugo-Galley
Hugo-Galley deleted the feat/add-french-langage branch September 25, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants