fix: support DB graphs without blocking Logseq UI - #405
Open
yuanlizbyy wants to merge 3 commits into
Open
yuanlizbyy wants to merge 3 commits into
yuanlizbyy wants to merge 3 commits into
Conversation
Query journal data as scalar values instead of pulling full page entities, and use the Logseq theme API instead of reading top.document. This prevents the plugin iframe from throwing a SecurityError and leaving an input-blocking overlay in Logseq DB graphs.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Logseq 2.x serves the host and plugin iframe from different origins (
lsp://logseq.comandlsp://logseq.io). Accessingtop.documentduring render throws aSecurityError. By that point Logseq has already made the full-screen plugin iframe visible, so the transparent iframe blocks input and makes the application appear frozen.PR #404 updates the DB attribute names, but pulled entities in DB graphs still expose namespaced keys. Returning journal day and page name as scalar query results avoids that version-sensitive object shape and avoids pulling unnecessary entity data.
Theme detection now uses
logseq.App.getUserConfigs()andlogseq.App.onThemeModeChanged()instead of reading the host DOM.Verification
pnpm buildSecurityErroris raisedThis includes the commits from #404 with the original author attribution preserved.