Conversation
Contributor
Author
|
@pdeljanov verified using a PR in my Symphonia fork, but the bots are also running here so that should increase confidence. I think the most complex part of this YML configuration is the logic for generating the code coverage comment, but it is a good next step until we move to a more robust system (if desired). |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernizes the GitHub Actions CI workflow to add code coverage reporting, MSRV verification, documentation link checking, and build caching while streamlining cross-platform testing.
In this initial PR, code coverage is surfaced through codecov, which posts a comment posted back to the PR that caused the code coverage run to occur.
Key Changes
Code Coverage (using codecov)
MSRV Verification
Added an
msrvjob verifying that the workspace compiles against Rust 1.85 (as specified inCargo.toml).Documentation Verification
Added a
docsjob runningRUSTDOCFLAGS="-D warnings" cargo doc --workspace --all-features --no-depsto guard against broken intra-doc links and doc-build regressions.Build Caching (
Swatinem/rust-cache)Added caching for
~/.cargoand build targets across matrix runners, significantly speeding up PR CI runs.Standard Toolchain Management
Standardized toolchain and component installation with
dtolnay/rust-toolchainandtaiki-e/install-action.Workflow Concurrency
Added
concurrency.cancel-in-progressto automatically cancel superseded runs when pushing new commits to open PRs.NOTE: Verified using a test PR in my repository fork: baylesj#2