isomp4: relax the pending atom check for seekable source - #536
Open
kassiansun wants to merge 1 commit into
Open
kassiansun wants to merge 1 commit into
kassiansun wants to merge 1 commit into
Conversation
scroix
added a commit
to BlueJayLouche/rustjay-engine
that referenced
this pull request
Aug 13, 2026
…108) The reopen-on-EOF workaround for pdeljanov/Symphonia#536 replaced `inner` with a fresh reader before seeking it. If the seek then failed (isomp4 0.6 returns OutOfRange for a target past the end instead of clamping), the decoder was left rewound to the start with eof cleared, so the next read() replayed audio from the beginning instead of staying silent at EOF. Seek the fresh reader first and commit it to `inner` only on success. Adds a regression test that builds an M4A fixture from Ping.aiff with afconvert.
Closed
4 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if we seek a m4a decoder after reaching eof, the pending atom is none, and the
next_packetwill fail. Relax the check for seekable stream, so theseek_readerwill properly handle this case later.