Disable flakehub API call in dart CI - #1810
Merged
Merged
Conversation
PR payjoin#1798 added `use-flakehub: false` to every workflow that uses magic-nix-cache-action, but dart.yml was missed. It still calls the FlakeHub API on every run even though the project has no FlakeHub account, which is the behaviour that PR set out to remove. Align dart.yml with csharp.yml, javascript.yml, python.yml, rust.yml, format.yml and crates-release.yml.
Collaborator
Coverage Report for CI Build 31883237660Coverage remained the same at 86.718%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dart.ymlis the only workflow still callingmagic-nix-cache-actionwithoutuse-flakehub: false.#1798 added the flag to
crates-release.yml(4 call sites),csharp.yml,format.yml,javascript.yml,python.ymlandrust.yml, butdart.ymlgotmissed, so it's still hitting the FlakeHub API on every run even though we
don't have an account. Same behaviour #1798 was removing everywhere else.
I went through every
magic-nix-cache-actioncall site under.github/workflows/and this was the only one left without the flag.Worth flagging: the dart workflow won't actually run on this PR. Its
pull_requestfilter ispayjoin-ffi/**,flake.nixandflake.lock, soediting
.github/workflows/dart.ymldoesn't match and the job stays skipped.The change is unexercised until something under
payjoin-ffi/next touches it.I left the filter alone rather than widen it here, but happy to if you'd
rather workflow edits triggered their own job.
Disclosure: co-authored by Claude Code. It found the gap, wrote the patch and
drafted this description. I reviewed and verified it.