Bump payjoin to version 1.0.0 - #1801
Merged
Merged
Conversation
benalleng
requested review from
DanGould and
spacebear21
and removed request for
spacebear21
August 7, 2026 18:34
Member
|
I think the 1.0 changelog should probably have a collation of the release candidates to show the difference between 0.25 while making it clear that they were added release candidate by release candidate. I'm not completely sure if we need a migration guide from 0.25 because so far we have close relationships with integrators and it might just make more sense to you know, reflect on our documentation and improve it as feedback arises. I don't foresee anyone asking for a migration guide from 0.25 to 1.0 We don't have to overthink it. |
spacebear21
force-pushed
the
bump-payjoin-1-0
branch
from
August 10, 2026 16:06
7a74606 to
e89c58e
Compare
spacebear21
marked this pull request as ready for review
August 10, 2026 16:07
Collaborator
Coverage Report for CI Build 31407204984Coverage remained the same at 86.718%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before merging I have some questions about how we should structure the changelog.
Should we be comparing this against the
payjoin-0.25tag orrc-8If we are comparing against the last non release candidate should we include changes in the changelog from each rc?Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.