Skip to content

Prefer MSRV-compatible deps in the ubrn build #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spacebear21 merged 1 commit into from
Aug 5, 2026
+6 −4
Merged

Prefer MSRV-compatible deps in the ubrn build #1797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions payjoin-ffi/javascript/scripts/generate_bindings.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@ if [[ $OS == "Darwin" && -z ${IN_NIX_SHELL:-} ]]; then
echo "LLVM flags set: AR=$AR, CC=$CC"
fi

# Heinous hack to pin a transitive dependency to be MSRV compatible on 1.85
cd node_modules/uniffi-bindgen-react-native
cargo add home@=0.5.11 --package uniffi-bindgen-react-native
cd ../..
# The ubrn command is compiled from source during the build below, from a
# workspace that ships no lock file, so cargo resolves it fresh every run and
# picks up crates whose MSRV has moved past this shell's toolchain. Ask cargo
# to prefer versions compatible with the rustc in use instead of pinning each
# drifting crate by hand.
export CARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS=fallback

# rustup target add is a no-op against a nix-provided toolchain
# (no rustup home, targets baked into the nix derivation instead).
Expand Down
Loading