Skip to content

fix(GlobeIcon): Replace GlobeIcon with RhUiLanguageFillIcon#12470

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-globe-icon-with-rh-ui-language-fill
Open

fix(GlobeIcon): Replace GlobeIcon with RhUiLanguageFillIcon#12470
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-globe-icon-with-rh-ui-language-fill

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 15, 2026

Copy link
Copy Markdown
Member

What:
This is one piece of #12400. Breaking it up by icon so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated the icon used in the DescriptionList component examples for improved visual consistency.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 967f6585-2982-45aa-9b71-dc4f66d1538b

📥 Commits

Reviewing files that changed from the base of the PR and between 8b528bb and c39a502.

📒 Files selected for processing (2)
  • packages/react-core/src/components/DescriptionList/examples/DescriptionList.md
  • packages/react-core/src/components/DescriptionList/examples/DescriptionListIconsOnTerms.tsx

Walkthrough

The GlobeIcon used for the "Pod selector" term in the DescriptionListIconsOnTerms example is replaced with RhUiLanguageFillIcon. The import is updated in both the TSX example component and the markdown documentation file.

Changes

DescriptionList Icon Example Update

Layer / File(s) Summary
Replace icon in example and docs
packages/react-core/src/components/DescriptionList/examples/DescriptionListIconsOnTerms.tsx, packages/react-core/src/components/DescriptionList/examples/DescriptionList.md
Swaps GlobeIcon import and icon prop usage with RhUiLanguageFillIcon for the "Pod selector" DescriptionListTerm, and updates the corresponding icon import in the markdown docs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • patternfly/patternfly-react#12369: Modifies the same DescriptionListIconsOnTerms.tsx and DescriptionList.md files by swapping icon imports and usages in the DescriptionList example.

Suggested labels

Needs design review

Suggested reviewers

  • phcox
  • nicolethoen
  • thatblindgeye
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: replacing GlobeIcon with RhUiLanguageFillIcon across the files in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants