fix(BullhornIcon): Replace BullhornIcon with RhUiAttentionBellFillIcon

[rebeccaalpert]

What:
This is one piece of #12400. Breaking it up by icon so it is easier to review.

I wasn't sure if this was a good replacement so let me know if you want something else. Bullhorn has no direct equivalent in the new icon set.

Additional issues:

Summary by CodeRabbit

• Chores
  • Updated Modal and Popover example implementations and related fixtures to use the same alternative icon for “custom title/icon” display.
• Documentation
  • Refreshed Modal and Popover examples documentation text and icon imports to match the updated custom icon behavior.
• Tests
  • Adjusted Modal “custom icon variant” test cases and snapshots to use the updated icon.

[coderabbitai]

Walkthrough

Replaces BullhornIcon with RhUiAttentionBellFillIcon across Modal (current and deprecated) and Popover component examples, example documentation markdown, and custom icon variant snapshot tests. No component APIs, exports, or logic are changed.

Changes

Icon substitution across Modal and Popover

Layer / File(s)	Summary
Modal and Popover examples and docs packages/react-core/src/components/Modal/examples/ModalCustomTitleIcon.tsx, packages/react-core/src/components/Modal/examples/Modal.md, packages/react-core/src/components/Popover/examples/PopoverWithIconInTheTitle.tsx, packages/react-core/src/components/Popover/examples/Popover.md, packages/react-core/src/deprecated/components/Modal/examples/ModalCustomTitleIcon.tsx, packages/react-core/src/deprecated/components/Modal/examples/Modal.md	Icon import swapped from BullhornIcon to RhUiAttentionBellFillIcon in all Modal and Popover example TSX files and their markdown documentation, for both the current and deprecated Modal paths.
Snapshot tests packages/react-core/src/components/Modal/__tests__/ModalBoxTitle.test.tsx, packages/react-core/src/deprecated/components/Modal/__tests__/ModalBoxTitle.test.tsx	Custom icon variant snapshot tests in both the current and deprecated ModalBoxTitle test files updated to import and pass RhUiAttentionBellFillIcon instead of BullhornIcon.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• patternfly/patternfly-react#12376: Updates component test snapshots to use different RH brand icons by swapping icon imports and related props in example files and tests.

Suggested labels

Needs design review

Suggested reviewers

• nicolethoen
• phcox
• kmcfaul
• thatblindgeye
• wise-king-sullyman

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: replacing BullhornIcon with RhUiAttentionBellFillIcon across multiple test, documentation, and example files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

packages/react-core/src/components/Modal/examples/Modal.md (1)

98-101: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Both Modal docs still describe the old icon after the swap. The shared root cause is stale explanatory copy that still says “bullhorn icon” while examples now use RhUiAttentionBellFillIcon.

• packages/react-core/src/components/Modal/examples/Modal.md#L98-L101: update the “Custom title icon” description to name the new icon (or use generic wording like “attention bell icon”).
• packages/react-core/src/deprecated/components/Modal/examples/Modal.md#L112-L115: apply the same wording update in the deprecated docs section for consistency.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/react-core/src/components/Modal/examples/Modal.md` around lines 98 -
101, Update the explanatory text for the "Custom title icon" section in both
Modal documentation files to reflect the current icon being used. In
packages/react-core/src/components/Modal/examples/Modal.md at lines 98-101,
replace the reference to "bullhorn icon" with either the specific icon name
"RhUiAttentionBellFillIcon" or generic wording like "attention bell icon" to
match the actual example implementation. Apply the identical wording update to
packages/react-core/src/deprecated/components/Modal/examples/Modal.md at lines
112-115 to keep the deprecated docs consistent with the primary documentation.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@packages/react-core/src/components/Modal/examples/Modal.md`:
- Around line 98-101: Update the explanatory text for the "Custom title icon"
section in both Modal documentation files to reflect the current icon being
used. In packages/react-core/src/components/Modal/examples/Modal.md at lines
98-101, replace the reference to "bullhorn icon" with either the specific icon
name "RhUiAttentionBellFillIcon" or generic wording like "attention bell icon"
to match the actual example implementation. Apply the identical wording update
to packages/react-core/src/deprecated/components/Modal/examples/Modal.md at
lines 112-115 to keep the deprecated docs consistent with the primary
documentation.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 22affc0a-c915-403f-be7e-67cb7bfc995c

📥 Commits

Reviewing files that changed from the base of the PR and between 8b528bb and abc29b1.

⛔ Files ignored due to path filters (2)

• packages/react-core/src/components/Modal/__tests__/__snapshots__/ModalBoxTitle.test.tsx.snap is excluded by !**/*.snap
• packages/react-core/src/deprecated/components/Modal/__tests__/__snapshots__/ModalBoxTitle.test.tsx.snap is excluded by !**/*.snap

📒 Files selected for processing (8)

• packages/react-core/src/components/Modal/__tests__/ModalBoxTitle.test.tsx
• packages/react-core/src/components/Modal/examples/Modal.md
• packages/react-core/src/components/Modal/examples/ModalCustomTitleIcon.tsx
• packages/react-core/src/components/Popover/examples/Popover.md
• packages/react-core/src/components/Popover/examples/PopoverWithIconInTheTitle.tsx
• packages/react-core/src/deprecated/components/Modal/__tests__/ModalBoxTitle.test.tsx
• packages/react-core/src/deprecated/components/Modal/examples/Modal.md
• packages/react-core/src/deprecated/components/Modal/examples/ModalCustomTitleIcon.tsx

[patternfly-build]

Preview: https://pf-react-pr-12466.surge.sh

A11y report: https://pf-react-pr-12466-a11y.surge.sh