bench hash added - #409
Open
michalkucharczyk wants to merge 26 commits into
Open
bench hash added#409michalkucharczyk wants to merge 26 commits into
michalkucharczyk wants to merge 26 commits into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Author
|
results are here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds hashing benchmarks comparing PVM vs native execution, used to decide whether the JAM Parachain Service needs crypto host calls.
Two components added:
bench-hashguest crate exporting thesp_io::hashingfunctions (blake2, keccak, sha2, twox) as parameterizedbenchmark_<algo>(len, times)entry points,bench-hashsubcommand that runs them over a size grid on the PVM blob and native libraries, printing raw per-iteration times (process-results.shturns the CSV into comparison tables).Along the way this exposed that
bench-common.rs's byte-at-a-timememcpy/memsetshadowcompiler_builtins' weak word-wise versions that real-world guests link. This inflated small-input results by up to 2.4× under sync gas metering (keccak_256 @ 32 B: 1.19 µs → 497 ns). They are now gated behind a per-cratebuiltins-memfeature (default-on only forbench-hash, so existing benchmark numbers are unaffected).