Skip to content

integration tests: 5 of 9 test targets are never run in CI #394

Description

@Imod7

Description

cargo test --package integration_tests builds 9 test targets. ci.yml runs 4 of them. The other 5 have never executed in CI, so 83 tests provide no signal.

Verified with cargo test --package integration_tests --no-run, which lists all 9 executables.

Running today: basic and accounts (via --test), plus latest and historical (via the seven test_{latest,historical}_* name filters).

Never run:

Target Tests What it needs to run
chain_config 10 Nothing. The tests are plain #[test], no HTTP client, no server.
capabilities 1 A running server (API_URL). Any chain.
use_rc_block 7 A running server (API_URL). Asset Hub, with a relay chain configured.
relay_chain_connection 4 An Asset Hub server with a relay chain configured.
coretime 61 A separate server pointed at a coretime chain (Broker pallet), e.g. wss://kusama-coretime-rpc.polkadot.io.

Why it matters

coretime alone is 61 tests, the second largest suite in the repo after accounts. The coretime endpoints have no CI coverage of any kind.

chain_config is the odd one out and the clearest gap: it needs no server and no network, so it could join the existing unit test job as-is. There is no cost argument for leaving it out.

Why it happened

The same reason as #391: adding a test file does not wire it into CI, and nothing fails when you skip that step. ci.yml names each suite explicitly, so a new target is silently absent until someone notices.

Suggested fix

Do not wire all 5 in one PR. They need different setups and some may have their own drift, exactly as accounts did (#391 found 4 broken tests in a suite nobody had run).

Suggested order, cheapest first:

  1. chain_config: no server needed, add to the existing unit test job.
  2. capabilities and use_rc_block: add to the Asset Hub Polkadot job, reusing the server already started there.
  3. relay_chain_connection: same job, but confirm the relay chain is configured in that step.
  4. coretime: needs its own server and chain; the largest piece of work.

Run each suite locally before wiring it, and expect failures. Budget is not the obstacle: the Asset Hub Polkadot job already spends around 400s on test_historical_asset_hub_polkadot.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions