Conversation
7f73849 to
f6457f1
Compare
|
@pgherveou @eugypalu all required checks are green, including Rust/Clippy, Android, iOS, browser artifacts, and license policy. Could one of you provide the required host-sdk-team approval so the merge queue can admit this dependency? |
pgherveou
left a comment
There was a problem hiding this comment.
can we remove the generated files in the new js packages. Can't these be built from the src files ?
for the new bindings we can also added then to .gitattributes with linguist-generated=true, so that at least they show up as generated artifacts in the code review
|
Addressed in b0e178e: removed the committed browser |
|
Cleanup CI is fully green; ready for rereview and merge queue admission. |
|
DQ: why do all these things need to live in host-rust-core, they don't seem to have dependency on the rust-core stuff, and could be shipped independently ? |
b0e178e to
e0f05c4
Compare
|
They share the Rust core directly rather than only co-locating artifacts:
They could be split, but that would duplicate the Rust source/pins and create independent browser, XCFramework, and AAR versioning with an ABI-drift boundary. Keeping the runtime here makes the host-neutral Rust implementation the single source for all three targets; Epoca/Dotli/Brevity/Desktop remain independent consumers. |
|
Does that shared Rust/UniFFI dependency path resolve the repository-placement concern, or do you want the runtime split into a separate repository before merge? |
|
Additional review completed. Fixed three concrete boundary issues:
Added behavioral browser tests for malformed launch inputs and cross-profile framebuffer submission. Full workspace result: 1,205 tests passed, Clippy Vendored commit |
|
PolkaVM dependency update:
|
23f50c6 to
d0e16fc
Compare
|
Rebased the full PVM series onto current Post-rebase verification:
The PR is now up to date with |
|
Added in 2c08d25:
Consumer cutovers:
Verification remains green: |
|
The repository-placement concern is now resolved by the extraction:
Generated browser output remains source-built and verified in the standalone repository; committed Swift/FFI bindings are marked generated. The full bridge matrix is green. |
8daab08 to
5e04221
Compare
Keep schema-change, emission-idempotence, and compiled-consumer coverage rather than pinning the generated wire-schema fingerprint to one API snapshot.
# Conflicts: # Cargo.lock # rust/crates/truapi-codegen/tests/golden/dispatcher.rs # rust/crates/truapi-codegen/tests/golden/wire_table.rs # rust/crates/truapi-server/src/host_logic/attestation.rs # rust/crates/truapi-server/src/runtime/signing_host/allowance_renewal.rs
iOS simulator previewBuilt from gh run download 35282939676 --name simulator-preview-749cf906b
unzip polkadot-app-*.app.zip
xcrun simctl install booted polkadot-app.app
xcrun simctl launch booted io.parity.polkadotapp.developOr download it in a browser, which arrives as a zip wrapping An arm64 simulator slice, so it needs an Apple Silicon Mac and does not |
# Conflicts: # CHANGELOG.md # README.md # js/packages/truapi-host/CHANGELOG.md # js/packages/truapi-host/README.md # rust/crates/truapi-server/src/lib.rs
Summary
truapi-pvm-hostwith the optionaltruapi-polkavm-host0.2.0 composition cratepolkavm-host-runtime0.3.0 ate60a6135be6e00c72c90ca4abe23d2002f4eb962; report that same immutable revision through the composition cratetruapi-serverindependent of PolkaVMpolkavm-host-runtimeowns those distribution artifactsarmeabi-v7aBoundary
truapi-polkavm-hostis an rlib-only composition dependency. It exposes the namespacedpolkavm_host_runtimeandtruapi_serverAPIs plus pinned version/revision constants. Downstream distribution crates decide which native ABI surfaces to export. Chat authority remains in #709, not this generic base.CI follow-up
Current source and consumers
e69940f46692f7fc5c0c0e77f910eb0aa02c7442Local verification
RUSTFLAGS='-D warnings' cargo check --target wasm32-unknown-unknown -p truapi-server: passedRUSTFLAGS='-D warnings' cargo test --workspace --all-features --no-fail-fast: 1,310 passed, 21 ignored0.3.0and sourcee60a6135be6e00c72c90ca4abe23d2002f4eb962Fresh GitHub checks run on this update. This update is not a merge, release, or deployment.