Repository navigation
Record the blueprint palette rules and a third scope recurrence - #161
Merged
Merged
Conversation
DESIGN.md gains the two rules the old palette broke: decoration must not borrow meaning (it was literally Slack, Jira, Discord, Google and GitHub hexes, the same ones ConnectionLogos uses to identify those services), and the hash must use the whole id plus a finalizer, since ids are namespaced and gradients.length is a power of two. AGENTS.md gains the third recurrence of the scope rule in one day, in its least visible form: a post-deploy grep returned six zeros because the values lived in a lazily-loaded chunk, and six zeros read as a clean result. A sanity row -- does this file contain any gradient class at all -- returns 0 against the wrong chunk and 6 against the right one. Pair every expect-0 assertion with an expect-greater-than-0 that proves the file was actually read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records only. Two markdown files, zero code.
DESIGN.md— the blueprint gradientsDocuments the two rules the previous palette broke, so the next person changing it knows why it looks the way it does:
ConnectionLogos.tsxuses to identify those real services — so an unrelated blueprint was decorated to look like a Slack integration.id.charCodeAt(0)collides by construction. And becausegradients.lengthis a power of two, a bare*31polynomial is not enough either:31 ≡ 7 (mod 8)leaves almost no entropy in the low bits.With the note that this matters more here than it would elsewhere — preview placeholders are permanent on this fork, so the gradient is the only per-blueprint mark those cards will ever carry.
AGENTS.md— the scope rule, third recurrence in one dayThis one is worth having because of the form it took. A post-deploy check grepped
workspace._id-*.jsfor six colour values and got six zeros, which reads as a clean result. The values were in a lazily-loadedBlueprintPreviewImage-*.jschunk, so the check had been reading a file that could not contain them.A sanity row catches this instantly: "does this file contain any gradient class?" returns 0 against the wrong chunk and 6 against the right one. That is the cheapest possible guard and the one most often left out.
The rule now says: pair every "expect 0" assertion with an "expect >0" that proves the file was actually read.
Verified in use — the corrected
alpha.13check baselined 1 pass / 7 fail against the previous release, then 8/8 after the deploy, with the chunk hash changingB_jwn1b1→z3sCEgcD.