Repository navigation
fix(format): preserve indentation on recipe continuation lines - #32
Merged
Merged
Conversation
The formatter flattened every recipe line to a single tab, discarding the extra indentation authors use on backslash continuations. Make only strips the first tab, so the remaining whitespace is passed to the shell. The reindent was a semantic change, not just cosmetic. Track continuation state across lines and, for continuations, keep the leading whitespace verbatim while still guaranteeing the tab. Non-continuation recipe lines are normalised as before, so neither indentation style is imposed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatter flattened every recipe line to a single tab, discarding the extra indentation authors use on backslash continuations. Make only
strips the first tab, so the remaining whitespace is passed to the shell, thehe reindent was a semantic change, not just cosmetic.
Track continuation state across lines and, for continuations, keep the leading whitespace verbatim while still guaranteeing the tab.
Non-continuation recipe lines are normalised as before, so neither indentation style is imposed.
Resolves #31