AO3-7435 Fix bug where saving changes on unsorted canonical tag gives 500 error. - #5872
Open
nightlight521 wants to merge 3 commits into
Open
AO3-7435 Fix bug where saving changes on unsorted canonical tag gives 500 error.#5872nightlight521 wants to merge 3 commits into
nightlight521 wants to merge 3 commits into
Conversation
| it "does not raise and redirects to success message" do | ||
| expect do | ||
| put :update, params: { id: unsorted_tag, commit: "Save changes" } | ||
| end.not_to raise_error |
Member
There was a problem hiding this comment.
You don't need this check for no errors raised. If this put raises an error, the tests will fail.
nightlight521
force-pushed
the
AO3-7435
branch
from
August 25, 2026 15:34
221b792 to
7d1d9e4
Compare
github-actions
Bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
redsummernight
added
Reviewed: Ready to Merge
and removed
Coder Has Actioned Review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7435
Purpose
Ignores missing tag hash which occurs when an empty update happens on an unsorted canonical tag, fixes undefined call on nil.
References
Should unblock AO3-7436