Let pybind11 modules release the GIL when used with free-threaded Python - #216
Open
sebp wants to merge 1 commit into
Open
Let pybind11 modules release the GIL when used with free-threaded Python#216sebp wants to merge 1 commit into
sebp wants to merge 1 commit into
Conversation
Raise minimum required version for dependencies that added support for free-threaded Python when using Python 3.14 or later.
Contributor
|
@sebp - the osqp C++ bindings for python are not thread-safe though, so I'm fairly certain that we do need to hold the GIL. Do you have evidence to the contrary? |
Author
|
@vineetbansal I do not have evidence that the C++ code is thread-safe. I would consider this PR as an experiment to provide free-threaded wheels so that thread-safety can be evaluated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While free-threading wheels are being built, the pybind11 modules currently do not release the GIL. Therefore, when running osqp with free-threaded Python, one gets the warning:
This pull request releases the GIL, based on https://pybind11.readthedocs.io/en/stable/advanced/misc.html#free-threading-support
Minimum required version for dependencies have been raised to versions that added support for free-threaded Python when using Python 3.14 or later.